Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | Versioning | Delete Objects | Add a Test | GPFS #8371

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Sep 17, 2024

Explain the changes

  1. Adding tests for deleting objects in GPFS.

Issues:

  1. As a part of NSFS | S3 | Versioning: DeleteObjects response does not return Deleted record #8360 issue we should test delete objects on GPFS machine after the fix of NSFS | GPFS | fix delete latest object twice on GPFS #8358 and add this test to the tests that we can run on the GPFS machine.

Testing Instructions:

  1. Not yet, would be tested on the GPFS machine.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Sep 17, 2024
@shirady
Copy link
Contributor Author

shirady commented Sep 18, 2024

Validation on GPFS cluster:

I used this RPM: noobaa-core-5.18.0-20240917-nsfs-nc-versioning-fixes.el9.x86_64.rpm
Which was created from this branch: nsfs-nc-versioning-fixes

Cluster node:

  1. We created an account using noobaa-cli: noobaa-cli account add --name s3user-5001 --uid 5001 --gid 5001 --new_buckets_path /ibm/fs1/teams/ (note new_buckets_path is running on GPFS, you can run df -T /ibm/fs1/teams/)

Client node:
2. Created the alias s3-u1='AWS_ACCESS_KEY_ID=<access-key> AWS_SECRET_ACCESS_KEY=<secret-key> aws --no-verify-ssl --endpoint https://1<ip-address-of-node>:6443/ --no-verify-ssl'

  1. create a bucket: s3-u1 s3 mb s3://user-5001-b03; echo $?
make_bucket: user-5001-b03
0
  1. versioning enabled: s3-u1 s3api put-bucket-versioning --bucket user-5001-b03 --versioning-configuration Status=Enabled and then s3-u1 s3api get-bucket-versioning --bucket user-5001-b03
{
    "Status": "Enabled"
}
  1. delete-objects: s3-u1 s3api delete-objects --bucket b5001-01 --delete file://delete.json/
    delete.json:
{
  "Objects": [
    {
      "Key": "non-existing-key.txt"
    }
  ],
  "Quiet": false
}
{
    "Deleted": [
        {
            "Key": "non-existing-key.txt",
            "DeleteMarker": true,
            "DeleteMarkerVersionId": "mtime-d49g3bunmha8-ino-4s8w"
        }
    ]
}

Outputs are as expected, no errors.
@romayalon @nadavMiz

@shirady shirady force-pushed the nsfs-nc-versioning-delete-objects branch from 16a2d06 to f94e627 Compare September 18, 2024 14:34
@shirady shirady force-pushed the nsfs-nc-versioning-delete-objects branch from f94e627 to f0f8899 Compare September 18, 2024 16:15
@shirady shirady merged commit 5819f58 into noobaa:master Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants